Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring opportunity - duplicated code #5836

Open
tristan81 opened this issue Sep 20, 2024 · 1 comment
Open

refactoring opportunity - duplicated code #5836

tristan81 opened this issue Sep 20, 2024 · 1 comment

Comments

@tristan81
Copy link
Contributor

Duplicated onscroll event code for Nearby and Explore map viewers, could be refactored to remove duplication.

ExploreMapFragment
image

NearbyParentFragment
image
@tristan81 tristan81 mentioned this issue Sep 22, 2024
Closed
@RitikaPahwa4444
Copy link
Collaborator

RitikaPahwa4444 commented Sep 25, 2024 •
edited
Loading

Thanks for spotting this! Linking an older issue for anyone planning to take this one up as previous attempts to remove redundant code didn't turn out as intended: #5256. Taking a look at the merged PR might help as several cases were covered in it and would save a lot of time as we would be aware of the changes that might break the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tristan81 @RitikaPahwa4444