-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Test rework, next #3461
Draft
apostasie
wants to merge
5
commits into
containerd:main
Choose a base branch
from
apostasie:qa-netgen-part-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Test rework, next #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
qa-netgen-part-3
branch
from
September 24, 2024 03:34
f363f0c
to
2df62c7
Compare
apostasie
force-pushed
the
qa-netgen-part-3
branch
8 times, most recently
from
September 24, 2024 18:39
af64720
to
45f100f
Compare
apostasie
force-pushed
the
qa-netgen-part-3
branch
2 times, most recently
from
September 25, 2024 23:31
f5f3a8f
to
741bc21
Compare
This is blocked by #3435 (and obviously pending parts 2 and 3). |
apostasie
force-pushed
the
qa-netgen-part-3
branch
8 times, most recently
from
September 26, 2024 23:47
33511bf
to
18d5a80
Compare
As we make progress rewriting tests, the new tooling needs to adapt. In a shell, this is: - introducing (more) `Requirements`, with a better API - update documentation - fix some t.Helper calls - fix broken stdin implementation - do cleanup custom namespaces properly - change hashing function - disable "private" implying custom data root which is more trouble than is worth - minor cleanups Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Another raft of changes to the tooling as progress in rewriting is made, focused on: - better DX - more helpers for nerdtest (buildctl) - API fixes for test - allowing requirements to have access to helpers - documentation fixes Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
qa-netgen-part-3
branch
from
September 27, 2024 00:35
18d5a80
to
6ac785d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #3464
Contains work on image tests.