Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test rework, next #3461

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Sep 24, 2024

Based on top of #3464

Contains work on image tests.

@apostasie apostasie force-pushed the qa-netgen-part-3 branch 8 times, most recently from af64720 to 45f100f Compare September 24, 2024 18:39
@apostasie apostasie changed the title [WIP] Test rework, part 3 [WIP] Test rework, next Sep 25, 2024
@apostasie apostasie force-pushed the qa-netgen-part-3 branch 2 times, most recently from f5f3a8f to 741bc21 Compare September 25, 2024 23:31
@apostasie
Copy link
Contributor Author

apostasie commented Sep 25, 2024

This is blocked by #3435 (and obviously pending parts 2 and 3).
Temporarily cherry-picked the fix from there.

@apostasie apostasie force-pushed the qa-netgen-part-3 branch 8 times, most recently from 33511bf to 18d5a80 Compare September 26, 2024 23:47
As we make progress rewriting tests, the new tooling needs to adapt.
In a shell, this is:
- introducing (more) `Requirements`, with a better API
- update documentation
- fix some t.Helper calls
- fix broken stdin implementation
- do cleanup custom namespaces properly
- change hashing function
- disable "private" implying custom data root which is more trouble than is worth
- minor cleanups

Signed-off-by: apostasie <[email protected]>
Another raft of changes to the tooling as progress in rewriting is made, focused on:
- better DX
- more helpers for nerdtest (buildctl)
- API fixes for test
- allowing requirements to have access to helpers
- documentation fixes

Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant