-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test rework, part 3 #3464
base: main
Are you sure you want to change the base?
Test rework, part 3 #3464
Conversation
b7d49c6
to
1b7190c
Compare
1b7190c
to
a1224a3
Compare
@@ -56,54 +56,58 @@ func TestVolumePrune(t *testing.T) { | |||
} | |||
|
|||
// This set must be marked as private, since we cannot prune without interacting with other tests. | |||
testGroup := &test.Group{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern does not work here, as the Group
will run in Parallel
with other tests, breaking things for Docker.
It works with nerdctl because we are making the subtests pivate - for Docker, the subtests disable parallel, but since the parent stays parallel, it blows up.
Changing to a Test
parent instead of a group, and disabling parallel on the subtests.
28c0e5f
to
3811ad6
Compare
@AkihiroSuda this is ready - to be merged after #3455 |
@AkihiroSuda let me rebase this so we get a clean view (and might amend something). |
As we make progress rewriting tests, the new tooling needs to adapt. In a shell, this is: - introducing (more) `Requirements`, with a better API - update documentation - fix some t.Helper calls - fix broken stdin implementation - do cleanup custom namespaces properly - change hashing function - disable "private" implying custom data root which is more trouble than is worth - minor cleanups Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
3811ad6
to
2339dc5
Compare
Hitting 429 with Docker Hub :-( Otherwise, this is now rebased and ready. |
On top of #3455
Notably: