From f4fcc896de5ed904bd5b0515761301e96f2df99a Mon Sep 17 00:00:00 2001 From: srdtrk Date: Tue, 30 Jul 2024 11:37:52 +0900 Subject: [PATCH] style: fixed solhint warnings --- src/ICS02Client.sol | 8 ++++---- src/ICS26Router.sol | 6 ++++-- test/IbcIdentifiers.t.sol | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/ICS02Client.sol b/src/ICS02Client.sol index 6ec4fdc..2ab4294 100644 --- a/src/ICS02Client.sol +++ b/src/ICS02Client.sol @@ -10,11 +10,11 @@ import { Ownable } from "@openzeppelin/contracts/access/Ownable.sol"; contract ICS02Client is IICS02Client, IICS02ClientErrors, Ownable { /// @dev clientId => counterpartyInfo - mapping(string => CounterpartyInfo) private counterpartyInfos; - /// @dev clientId => client - mapping(string => ILightClient) private clients; + mapping(string clientId => CounterpartyInfo info) private counterpartyInfos; + /// @dev clientId => light client contract + mapping(string clientId => ILightClient client) private clients; /// @dev clientType => nextClientSeq - mapping(string => uint32) private nextClientSeq; + mapping(string clientType => uint32 nextClientSeq) private nextClientSeq; /// @param owner_ The owner of the contract constructor(address owner_) Ownable(owner_) { } diff --git a/src/ICS26Router.sol b/src/ICS26Router.sol index 9b2fb08..d789e66 100644 --- a/src/ICS26Router.sol +++ b/src/ICS26Router.sol @@ -12,12 +12,14 @@ import { IBCIdentifiers } from "./utils/IBCIdentifiers.sol"; import { IIBCAppCallbacks } from "./msgs/IIBCAppCallbacks.sol"; import { ICS24Host } from "./utils/ICS24Host.sol"; import { ILightClientMsgs } from "./msgs/ILightClientMsgs.sol"; -import "@openzeppelin/contracts/utils/ReentrancyGuard.sol"; +import { ReentrancyGuard } from "@openzeppelin/contracts/utils/ReentrancyGuard.sol"; /// @title IBC Eureka Router /// @notice ICS26Router is the router for the IBC Eureka protocol contract ICS26Router is IICS26Router, IBCStore, Ownable, IICS26RouterErrors, ReentrancyGuard { - mapping(string => IIBCApp) private apps; + /// @dev portId => IBC Application contract + mapping(string portId => IIBCApp app) private apps; + /// @dev ICS02Client contract IICS02Client private ics02Client; constructor(address ics02Client_, address owner) Ownable(owner) { diff --git a/test/IbcIdentifiers.t.sol b/test/IbcIdentifiers.t.sol index bae03a7..661a188 100644 --- a/test/IbcIdentifiers.t.sol +++ b/test/IbcIdentifiers.t.sol @@ -1,7 +1,7 @@ // SPDX-License-Identifier: UNLICENSED pragma solidity >=0.8.25 <0.9.0; -// solhint-disable custom-errors,max-line-length +// solhint-disable gas-custom-errors,max-line-length import { Test } from "forge-std/src/Test.sol"; import { IBCIdentifiers } from "../src/utils/IBCIdentifiers.sol";