Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ICS20Transfer "unwrap" functions #36

Open
gjermundgaraba opened this issue Aug 14, 2024 · 0 comments
Open

Refactor ICS20Transfer "unwrap" functions #36

gjermundgaraba opened this issue Aug 14, 2024 · 0 comments
Labels
enhancement Improvements

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Aug 14, 2024

In ICS20Transfer.sol we have two functions that "unwrap" (and more) the packet data: _unwrapSendPacketData() and _unwrapReceivePacketData().

They are hard to read and reason about, and if we could find a better way to handle all the logic it contains, it would be a big improvement to the ICS20Transfer code.

The UnwrappedPacketData has become big, complex and contains a lot of information that might be better suited elsewhere (some fields might just be kept local since they are not used many places, like the originatorChainIsSource field).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

No branches or pull requests

1 participant