trurl: run --trim query before --append query #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch there was not a way to add a query parameter to a URL,
removing the previous value if the parameter was already present in the
base URL.
I tried to use:
x () {
trurl --verify --trim query=foo --append "query=foo=$2" -- "$1"
}
But that didn't work since --trim query runs after --append query, so
the new value value added with --append also gets trimmed:
$ x 'https://example.org/?foo=hello&baz=boo' 'howdy'
https://example.org/?baz=boo
This patch makes trurl run --trim before --append so that using
--trim query=foo --append query=foo=bar works to set foo to bar
overwriting previous values of foo.
$ x 'https://example.org/?foo=hello&baz=boo' 'howdy'
https://example.org/?baz=boo&foo=howdy
I added a test for this, and I also added a test that tests that
--sort-query and --append query work together, since I noticed it was
missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch there was not a way to add a query parameter to a URL, removing the previous value if the parameter was already present in the base URL.
I tried to use:
But that didn't work since --trim query runs after --append query, so the new value value added with --append also gets trimmed:
This patch makes trurl run --trim before --append so that using --trim query=foo --append query=foo=bar works to set foo to bar overwriting previous values of foo.
I added a test for this, and I also added a test that tests that --sort-query and --append query work together, since I noticed it was missing.