Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a caution callout for updated_at #6117

Open
wants to merge 4 commits into
base: current
Choose a base branch
from
Open

Added a caution callout for updated_at #6117

wants to merge 4 commits into from

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Sep 23, 2024 •
edited
Loading

I've created this pull request following the Git issue: https://github.com/orgs/dbt-labs/projects/14/views/35?pane=issue&itemId=78645770

I've added added a caution callout / warning if data-type for updated_at doesn't match adapter configured default

Resolves #6012

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@nataliefiann nataliefiann requested a review from a team as a code owner September 23, 2024 11:46
@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 26, 2024 0:19am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 23, 2024
graciegoheen
graciegoheen reviewed Sep 23, 2024
View reviewed changes
website/docs/reference/resource-configs/updated_at.md Outdated
@@ -27,6 +27,12 @@ snapshots:

</File>

:::caution

You might get a warning if the data type of the `updated_at` column does not match the adapter-configured default.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbeatty10 Hi! This is for this warning - what do you think about this wording?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any scenario in which they wouldn't get a warning about the mismatch?

If not, then I'd suggest updating "might" to be "will" instead.

Other than that, this call-out looks good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 left review comments

@graciegoheen graciegoheen graciegoheen left review comments

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees

@graciegoheen graciegoheen

Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
4 participants
@nataliefiann @dbeatty10 @graciegoheen @matthewshaver