Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer workshop guide #6150

Open
wants to merge 29 commits into
base: current
Choose a base branch
from
Open

Conversation

MichelleBaird-DBT
Copy link
Contributor

@MichelleBaird-DBT MichelleBaird-DBT commented Sep 25, 2024

What are you changing in this pull request and why?

Adding an explorer guide. To be used in the coalesce explorer workshop and then later in an online explorer workshop a la zero to dbt.

Preview link

Checklist

  • [ x] I have reviewed the Content style guide so my content adheres to these guidelines.
  • [ nope] The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • [ x] I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Note: Will probably submit an additional pr on oct 1st once changes to dbt explorer are in preview. Will be replacing images with updated images.

Additional note: Kyle and Shelli, please give this pr a technical and pedagogical review. Mirna, please let me know if I've formatted everything here correctly. I used the sl qs as a guide.

ADDING OR REMOVING PAGES (if so, uncomment):

  • [? ] Add/remove page in website/sidebars.js
  • [ x] Provide a unique filename for new pages
  • [ ?] Add an entry for deleted pages in website/vercel.json
  • [ ?] Run link testing locally with npm run build to update the links that point to deleted pages
    Added question marks for steps I'm unsure of. Mirna, could you let me know if there's anything else I should be doing before we push to prod?

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 27, 2024 8:37am

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address labels Sep 25, 2024
- If you are already signed into dbt Cloud, sign out first!
- Enter your first name and last name
- Choose the “Exploring a dbt Mesh implementation with dbt Explorer” option.
- Agree to the terms of service and click the “Complete Registration” button. Wait about 30 seconds, and you’ll be in the dbt Cloud project for this course, already connected to a data warehouse!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a password option - i think we should mention they can enter the password given to them at the workshop (i assume)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichelleBaird-DBT this is what i saw:

Screenshot 2024-09-26 at 11 22 22

### Hands-On
- Review your project recommendations and choose one improvement to implement (such as adding a description to a primary key that’s missing one).

## What's next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichelleBaird-DBT added a 'what's next' - what do you think? also, would this be a good place to write about the 'coming soon or new features (such as aut exposures, model query history, and data health tiles)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so! Adding this now

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @MichelleBaird-DBT , this looks great! thank you for opening this up and made some small tweaks for you, but other than that it looks good to me! i have some questions that i posed but non are blockers. incredible job!

Copy link
Contributor Author

@MichelleBaird-DBT MichelleBaird-DBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for the review!

Added section for future improvements to explorer. Did not add bullet points for features that'd be in preview by Coalesce time. Used this slack message from Roxi as a ref https://dbt-labs.slack.com/archives/CSSHB76QL/p1727296314616569?thread_ts=1727291542.371399&cid=CSSHB76QL
capitalization consistent
- Sign out if you're already logged in.
- Enter your first name and last name.
- Select the **Exploring a dbt Mesh implementation with dbt Explorer** option.
- Use the password provided by the workshop facilitator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use passcode since that is the verbiage for the signup page?

- What sources can we see?

- Explore the **Tests** Tab
- Did we run the right test?, Which test were missing? Why?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comma here

@mirnawong1
Copy link
Contributor

thanks @swhite-dbt ! have folded in your feedback! @MichelleBaird-DBT have taken another pass and it's good on my end. is there any one else you'd like to have review?

@coapacetic
Copy link
Contributor

taking a quick look now team 👀

Copy link
Contributor

@coapacetic coapacetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments for your review @MichelleBaird-DBT

One big one, so requesting changes

Comment on lines +34 to +35
1. Go to this URL: https://cloud.getdbt.com/coalesce-workshop-signup:
- Sign out if you're already logged in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Go to this URL: https://cloud.getdbt.com/coalesce-workshop-signup:
- Sign out if you're already logged in.
1. Go to this URL: https://cloud.getdbt.com/coalesce-workshop-signup (Sign out if you're already logged in)

formatting here looked funky and extra colon at the end of the URL

<Lightbox src="/img/quickstarts/dbt-cloud/dbt_explorer_project_recs.png" width="80%" title="dbt Explorer's project recommendation tab" />

### Hands-On
- Review your project recommendations and choose one improvement to implement (such as adding a description to a primary key that’s missing one).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to leave this open ended to a the entire audience or guide them to a specific change?

If they are going to make a specific change, you should add the steps for making a change (go to the IDE, open a branch, etc. etc.).

Otherwise you leave yourself open to everyone trying something different and potential chaos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants