Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_posmov_fvc_data upcoming needs #71

Open
joesilber opened this issue May 12, 2020 · 0 comments
Open

get_posmov_fvc_data upcoming needs #71

joesilber opened this issue May 12, 2020 · 0 comments
Assignees

Comments

@joesilber
Copy link
Contributor

Currently, get_posmov_fvc_data matches each pos move db entry to FVC coordinates of positioner, for each positioner of each petal. It does the matching via timestamps. It then outputs a CSV file per positioner, containing those results + a bunch of other columns from the posmovedb.

Coming soon:

  • Saving EXPOSURE_ID and EXPOSURE_ITER to the database. Should simplify matching.
  • Saving OBS_X, OBS_Y, PTL_X, PTL_Y, PTL_Z to the database. These are from platemaker and from postransforms at the time of measurement.
  • I want to:
    • Shift all calibrations and xytest analysis out of PECS and into desimeter.
    • Use desimeter or platemaker results interchangeably.
    • Provide tools in desimeter that can do the analysis "instantly" for operators on the mountain.

To handle this, I suggest that we:

  1. Include the new columns in get_posmove_fvc_data.
  2. Factor out the part where it grabs data from posmovedb.
  3. Factor out the part where it saves a particular CSV file format.
  4. Make a new (similar) script for grabbing data without having to run desimeter.

So both get_posmov_fvc_data and the new script---let's call it get_posmov_data---can use (2) and (3) as well.

Does that sound like a good approach? Or would it be easier to just extend get_posmove_fvc_data with more options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants