Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desimodel.focalplane : include radius, and review correctness #17

Open
sbailey opened this issue May 27, 2016 · 3 comments
Open

desimodel.focalplane : include radius, and review correctness #17

sbailey opened this issue May 27, 2016 · 3 comments
Assignees
@sbailey
Labels
enhancement
Milestone
DC2017 Prep

Comments

@sbailey
Copy link
Contributor

sbailey commented May 27, 2016

Review correctness of desimodel.focalplane.FocalPlane. e.g. does a round trip of xy -> RA,dec -> xy work?

Add a function for determining the effective radius based upon the location of the fibers and the platescale.
@dkirkby
Copy link
Member

dkirkby commented May 27, 2016

You could also compare with the xy -> RA,dec -> xy transforms in specsim.transform.

@weaverba137
Copy link
Member

Is there any movement on this issue?

@weaverba137 weaverba137 added this to the DC2017 Prep milestone May 4, 2017
@weaverba137
Copy link
Member

Did this ever get reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbailey sbailey

Labels
enhancement
Projects
None yet
Milestone
DC2017 Prep
Development

No branches or pull requests
3 participants
@dkirkby @sbailey @weaverba137