Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated use of regex #46

Open
stevenklassen8376 opened this issue Mar 7, 2021 · 3 comments
Open

Deprecated use of regex #46

stevenklassen8376 opened this issue Mar 7, 2021 · 3 comments

Comments

@stevenklassen8376
Copy link

Ninka is giving me the following warning message:

Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^\s*[0-9]{ <-- HERE 1-2}+\s*[-)]/ at /opt/kss/lib/perl5/site_perl/Ninka/SentenceExtractor.pm line 117.

@stevenklassen8376
Copy link
Author

Changing the line to

s/^\s*[0-9]\{1-2\}+\s*[\-\)]//;

should fix it.

@ulm
Copy link

ulm commented Mar 7, 2021

PR #41 contains a different fix for the problem.

@stevenklassen8376
Copy link
Author

Excellent. I see it was committed in January of 2018. When are you planning to merge it into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants