Add manifest for building as a flatpak #13040
Conversation
|
Some other things I'm not sure about: Regarding the metainfo file, it contains a Perhaps the best solution would be to place it in the data directory and fill the release node during the cmake build. The file itself is an xdg standard and not flatpak specific so it would also be useful for deb/rpm and other kinds of builds. Would this be a good solution? The file also includes links to some screenshots, this are the screenshots that are shown on flathub and other app stores: https://flathub.org/apps/org.DolphinEmu.dolphin-emu Are there any that you'd like to use? |
|
|
It's not necessary for dolphin-emu Do you know if it has been updated recently? |
|
Ah, never mind then. |
This is all I could find: #12144 (comment) Most likely talking about the crash when a controller is disconnected mentioned in the release notes.
Do you know if there'll be a |
|
Looking at the output of |
|
I'd guess its more a matter of a couple of months rather than days 😅 |
| @@ -0,0 +1,92 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- Copyright 2016 Jeremy Newton --> | |||
There was a problem hiding this comment.
I wonder if we need to update the copyright. We'll probably need to leave this part at the very least (metadata is CC-BY-SA 3.0).
There was a problem hiding this comment.
Jeremy Newton is the maintainer of the fedora package from where this file was originally copied back in 2017, It's very likely that it has been entirely rewritten since then.
Changing the copyright is unlikely to be an issue if need be.
|
Could you drop the final commit and squash everything? About the release node commit: I believe you copied the |
includes the following: - org.DolphinEmu.dolphin-emu.metainfo.xml.in this file contains general information and metadata that is used by most linux based app stores (kde discover, gnome software, flathub.org, etc) to showcase dolphin. - fill_release_node.sh a script to automatically fill in the release information in the metainfo file when building the flatpak. - SDL2.json manifest to build the vendored version of SDL from the Exports directory, it's only temporarily needed until the kde runtime is updated with the current SDL2 version and should be deleted after. - org.DolphinEmu.dolphin-emu.yml the manifest itself.
|
Sorry I made a mess of the rebase, my tracking branch was on the wrong commit. I'll fix it. |
Apologies I didn't realise the licensing would be incompatible. It's a rather trivial shell script so I've written a simple four liner to replace it, I hope that's fine, if it isn't I can just delete it and squash again. Thank you for your help, what's the next step? Should I be looking into integrating it with the ci? |
|
I'll handle the CI infrastructure, so don't worry about that. Thanks for your work on the PR. Let me ask around and see if anyone has any problems with this. If there aren't, I'll merge. |
this matches the version currently being served on flathub
git describe --tags appends the short hash, this cleans up the output so that we only print the actual version string.
|
I fixed two small issues:
I haven't squashed again in case you'd rather drop them. |
Includes the following:
org.DolphinEmu.dolphin-emu.metainfo.xml.inthis file contains general information and metadata that is used by most linux based app stores (kde discover, gnome software, flathub.org, etc) to showcase dolphin.fill_release_node.sha script to automatically fill in the release information in the metainfo file when building the flatpak.SDL2.jsonmanifest to build the vendored version of SDL from theExportsdirectory, it's only temporarily needed until the kde runtime is updated with the current SDL2 version and should be deleted after.org.DolphinEmu.dolphin-emu.ymlthe manifest itself.