RFC - Half Pixel Offset for Linear Filter #13048
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverses the clamping since it is an issue in OpenGL where the clamping for the top was clamping the bottom and vice versa. clamp_tb (ie clamp_top and clamp_bottom) now store the clamping amount relative to the top and bottom rather than absolute values.
This seems to be a problem for even IRs when the user does not use the scaled EFB copies setting
|
I want to note something that exists in the the Main branch and is not affected by your changes: I'm not sure if it's an "issue" but when you go to 2x IR with scaled efb = off, the whole screen shifts up and left by ~1 pixel. It may also be present in higher even IRs, but due to the increased resolution the offset might not be obvious. I think it is more obvious in games that display small EFB copies, because the offset of 1 pixel is more pronounced (xenoblade torch bloom). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for feedback on approach to tackling the issue with using even IRs with "Scaled EFB Copies" disabled.
It's currently got #12982 included but that commit will be removed when that PR is merged and this will then be rebased on master again.
This fixes the corrupted minimap for Twilight Princess for GC, which is this issue, when using even IRs with "Scaled EFB Copies" disabled.
This also fixes the graphical issues in Sonic Heroes, which is this old issue, which again occurs with using even IRs with "Scaled EFB Copies" disabled.