Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameINI: Fixing More Mistakes #13081

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

PatrickFerry
Copy link
Member

Some changes for GameINI files with issues.

Fixes this issue already marked fixed: Issue 10703

I had seen the direction given in Issue 10186 for Sonic Heroes was to remove the setting disabling AA just because the Vertex Rounding was being enabled. The issue still happens at 1x IR as Vertex Rounding doesn't apply then so I am once again disabling AA.

These codes are actually Gecko codes so setting that correctly.

There were errors which pop up when running this game as the comments for AR codes need to be set with hash(#) instead of asterisk(*). I replaced those anyways.

Removed the url in the comment since it's inaccessible and not on wayback machine either.

Also corrected the GameID, the wrong one is listed.
Both UseXFB and UseRealXFB are obsolete since Hybrid XFB.
Hack is not a valid setting.

Also updated the GameID.
The wrong filename was used so the settings weren't being applied.

(All it does is reset the Texture Cache Accuracy to the default setting.)
The use of any anti-aliasing will cause graphical corruption, which occurs on the ground.

MaxAnisotropy is supposed to be for [Video_Enhancements], but also it doesn't cause any of the issues in game so it is being removed rather than set under the correct heading.

Added a comment on why these values are set.
…r: The Ultimate Fitness System

SafeTextureCacheColorSamples is supposed to be for [Video_Settings], but also the medium setting isn't enough to display the missing text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant