Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform check is troublesome for websocket shim #23

Open
jacobrosenthal opened this issue Sep 6, 2015 · 1 comment
Open

Platform check is troublesome for websocket shim #23

jacobrosenthal opened this issue Sep 6, 2015 · 1 comment

Comments

@jacobrosenthal
Copy link

Im developing a websocket version of bleno here.
https://github.com/jacobrosenthal/bleno/tree/websocket

This platform check doesnt work in that scenario so Im not successfully advertising.
https://github.com/don/node-eddystone-beacon/blob/master/lib/beacon.js#L128

Should bleno bindings return the underlying platform? or is there a way to push this check down into the bleno layer which better knows which bindings its using?

@jacobrosenthal jacobrosenthal changed the title Platform check is Platform check is troublesome for websocket shim Sep 6, 2015
@sandeepmistry
Copy link
Collaborator

Should bleno bindings return the underlying platform?

That would be the simplest solution for now.

or is there a way to push this check down into the bleno layer which better knows which bindings its using?

It's a possibility, but this would involve the bleno layer parsing the EIR data, and removing the flags. All for an OS X quirk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants