Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] support external blob #1545

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Feb 2, 2024

Related PR: containerd/nydus-snapshotter#580

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer imeoer force-pushed the external-blob branch 3 times, most recently from d099826 to bb6ff6e Compare February 2, 2024 09:52
@imeoer imeoer marked this pull request as ready for review February 2, 2024 09:53
@imeoer imeoer requested a review from a team as a code owner February 2, 2024 09:53
@imeoer imeoer requested review from bergwolf, power-more and Desiki-high and removed request for a team February 2, 2024 09:53
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 41.28920% with 337 lines in your changes are missing coverage. Please review.

Project coverage is 61.17%. Comparing base (d12634f) to head (5e6cdba).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
- Coverage   61.40%   61.17%   -0.24%     
==========================================
  Files         144      148       +4     
  Lines       46962    47428     +466     
  Branches    44498    44964     +466     
==========================================
+ Hits        28837    29012     +175     
- Misses      16646    16920     +274     
- Partials     1479     1496      +17     
Files Coverage Δ
builder/src/core/bootstrap.rs 77.63% <100.00%> (+0.29%) ⬆️
builder/src/core/chunk_dict.rs 69.93% <ø> (ø)
builder/src/lib.rs 64.66% <ø> (ø)
builder/src/merge.rs 70.79% <100.00%> (ø)
builder/src/stargz.rs 74.81% <100.00%> (+0.14%) ⬆️
builder/src/tarball.rs 63.40% <100.00%> (+0.56%) ⬆️
storage/src/backend/mod.rs 56.07% <ø> (ø)
storage/src/device.rs 69.13% <100.00%> (+0.09%) ⬆️
storage/src/meta/chunk_info_v1.rs 95.90% <100.00%> (ø)
utils/src/filemap.rs 94.32% <100.00%> (-0.23%) ⬇️
... and 19 more

... and 2 files with indirect coverage changes

@imeoer imeoer force-pushed the external-blob branch 3 times, most recently from 3e90986 to 58c3165 Compare February 8, 2024 03:03
@imeoer imeoer force-pushed the external-blob branch 4 times, most recently from b425987 to 80ad7d8 Compare February 8, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant