Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce useful error messages and support logging in the notification framework #18

Open
gervarro opened this issue Aug 14, 2017 · 2 comments

Comments

@gervarro
Copy link

The notification framework should produce useful error messages in the exceptions, which should result in meaningful log messages.

@anthonyanjorin
Copy link
Contributor

Just to add a concrete example: at the moment if you delete model elements in such a way that dangling objects without any container are left over, you get a Join-Failed exception with no explanation. While I agree that such a deletion is problematic and should be flagged as such (as opposed to just quietly ignoring it), a message that mentions the problematic objects with an explanation would be nice.

@anthonyanjorin
Copy link
Contributor

anthonyanjorin commented Jun 20, 2018

I now have someone in industry trying to use IBeX and the problem with "RuntimeExceptions" is really bad. We should try to improve the type and message of all exceptions. For example:

Exception in thread "main" java.lang.RuntimeException 
        at org.gervarro.democles.notification.emf.NotificationModule.issueNotificationsForInsertion(NotificationModule.java:174) 
        at org.gervarro.democles.incremental.emf.NotificationCollector.issueNotificationsForInsertion(NotificationCollector.java:161) 
        at org.gervarro.democles.incremental.emf.NotificationCollector.add(NotificationCollector.java:143) 
        at org.gervarro.democles.incremental.emf.ResourceLoadingMarker.notifyChanged(ResourceLoadingMarker.java:29) 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants