You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When building leshan, revapi reports something wrong with californium API. (I think this is not new but before I just ignored all error from californium and I changed my build config about that recently)
Report :
{"ignore": true,"code": "java.class.nonPublicPartOfAPI","new": "class org.eclipse.californium.scandium.dtls.DTLSFlight.EpochMessage","justification": "ADD YOUR EXPLANATION FOR THE NECESSITY OF THIS CHANGE""classSimpleName": "EpochMessage","exampleUseChainInNewApi": "org.eclipse.californium.scandium.dtls.DTLSFlight.EpochMessage is used as parameter in method void org.eclipse.californium.scandium.dtls.DTLSFlight::wrapMessage(org.eclipse.californium.scandium.dtls.DTLSFlight.EpochMessage) throws org.eclipse.californium.scandium.dtls.HandshakeException <- org.eclipse.californium.scandium.dtls.DTLSFlight is returned from method org.eclipse.californium.scandium.dtls.DTLSFlight org.eclipse.californium.scandium.dtls.Handshaker::createFlight() <- org.eclipse.californium.scandium.dtls.Handshaker is used as parameter in method void org.eclipse.californium.scandium.dtls.SessionListener::handshakeFlightRetransmitted(org.eclipse.californium.scandium.dtls.Handshaker, int) <- org.eclipse.californium.scandium.dtls.SessionListener is returned from method org.eclipse.californium.scandium.dtls.SessionListener org.eclipse.californium.scandium.dtls.Connection::getSessionListener() <- org.eclipse.californium.scandium.dtls.Connection is used as parameter in method void org.eclipse.californium.scandium.MdcConnectionListener::updateExecution(org.eclipse.californium.scandium.dtls.Connection) @ org.eclipse.leshan.transport.californium.PrincipalMdcConnectionListener (method void org.eclipse.californium.scandium.MdcConnectionListener::updateExecution(org.eclipse.californium.scandium.dtls.Connection) @ org.eclipse.leshan.transport.californium.PrincipalMdcConnectionListener is part of the API)","package": "org.eclipse.californium.scandium.dtls","classQualifiedName": "org.eclipse.californium.scandium.dtls.DTLSFlight.EpochMessage","elementKind": "class","newArchive": "org.eclipse.californium:scandium:jar:3.12.0","newArchiveRole": "supplementary",},
I copy/paste the exampleUseChainInNewApi here because this is the most important part to understand the issue :
org.eclipse.californium.scandium.dtls.DTLSFlight.EpochMessage is used as parameter in method void org.eclipse.californium.scandium.dtls.DTLSFlight::wrapMessage(org.eclipse.californium.scandium.dtls.DTLSFlight.EpochMessage) throws org.eclipse.californium.scandium.dtls.HandshakeException <- org.eclipse.californium.scandium.dtls.DTLSFlight is returned from method org.eclipse.californium.scandium.dtls.DTLSFlight org.eclipse.californium.scandium.dtls.Handshaker::createFlight() <- org.eclipse.californium.scandium.dtls.Handshaker is used as parameter in method void org.eclipse.californium.scandium.dtls.SessionListener::handshakeFlightRetransmitted(org.eclipse.californium.scandium.dtls.Handshaker, int) <- org.eclipse.californium.scandium.dtls.SessionListener is returned from method org.eclipse.californium.scandium.dtls.SessionListener org.eclipse.californium.scandium.dtls.Connection::getSessionListener() <- org.eclipse.californium.scandium.dtls.Connection is used as parameter in method void org.eclipse.californium.scandium.MdcConnectionListener::updateExecution(org.eclipse.californium.scandium.dtls.Connection) @ org.eclipse.leshan.transport.californium.PrincipalMdcConnectionListener (method void org.eclipse.californium.scandium.MdcConnectionListener::updateExecution(org.eclipse.californium.scandium.dtls.Connection) @ org.eclipse.leshan.transport.californium.PrincipalMdcConnectionListener is part of the API)",
"package": "org.eclipse.californium.scandium.dtls
Solution ?
I think EpochMessage class should be protected instead of private ?
I know this is part of @NoPublicAPI but even if this is not intended to be used the visibility seems inconsistent.
(tested with Cf 3.12.0)
The text was updated successfully, but these errors were encountered:
When building leshan, revapi reports something wrong with californium API. (I think this is not new but before I just ignored all error from californium and I changed my build config about that recently)
Report :
nonPublicPartOfAPI
is described here.I copy/paste the
exampleUseChainInNewApi
here because this is the most important part to understand the issue :Solution ?
I think
EpochMessage
class should be protected instead of private ?I know this is part of @NoPublicAPI but even if this is not intended to be used the visibility seems inconsistent.
(tested with Cf 3.12.0)
The text was updated successfully, but these errors were encountered: