Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember UI barfs when there are no grants for a Submission #1021

Open
emetsger opened this issue Aug 19, 2019 · 4 comments
Open

Ember UI barfs when there are no grants for a Submission #1021

emetsger opened this issue Aug 19, 2019 · 4 comments
Labels

Comments

@emetsger
Copy link
Contributor

emetsger commented Aug 19, 2019

This may be an issue with the policy service, not sure- I admit I haven't dug in to determine which -

Performing a submission where there are no grants for the submission results in the following:

Screen Shot 2019-08-19 at 9 54 10 AM

Even if the issue is with the policy service, probably the Ember UI should handle it more gracefully? Even with no grants, I should still be able to submit to the institutional repository.

As a note, this error condition is occurring with a local branch configured for Harvard, which can be found at https://github.com/emetsger/pass-docker, branch harvard-pass, commit 2c4735e71.

To replicate, check out that commit and:

  • remove all docker containers
  • remove all dangling volumes
  • docker-compose -f harvard.yml pull
  • docker-compose -f harvard.yml up -d

Then login as the nih-user and attempt to perform a submission.

@emetsger emetsger added the bug label Aug 19, 2019
@jrmartino
Copy link
Contributor

i saw this too, in the pass-docker setup

@emetsger
Copy link
Contributor Author

It should also be noted that the policy service used by this branch/commit does not have eclipse-pass/pass-policy-service#17 applied.

@jabrah
Copy link
Contributor

jabrah commented Aug 20, 2019

From the UI side, we can tie this into #922. We should make error handling a lot more robust in the Ember app

@htpvu
Copy link
Contributor

htpvu commented Sep 9, 2019

@jabrah @jrmartino is this still an issue in the latest pass-docker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants