From 739b44cdd193914fe618f9b7651871af98689848 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20M=C3=A4der?= <t.s.maeder@gmail.com>
Date: Wed, 26 Jun 2024 07:30:59 +0200
Subject: [PATCH] Addressing review comments
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
---
 .../src/electron-main/electron-main-application.ts    | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/packages/core/src/electron-main/electron-main-application.ts b/packages/core/src/electron-main/electron-main-application.ts
index 3c777499ac6b4..58e52aab154c0 100644
--- a/packages/core/src/electron-main/electron-main-application.ts
+++ b/packages/core/src/electron-main/electron-main-application.ts
@@ -32,7 +32,7 @@ import { ContributionProvider } from '../common/contribution-provider';
 import { ElectronSecurityTokenService } from './electron-security-token-service';
 import { ElectronSecurityToken } from '../electron-common/electron-token';
 import Storage = require('electron-store');
-import { CancellationTokenSource, Disposable, DisposableCollection, Path, isOSX, isWindows, nls } from '../common';
+import { CancellationTokenSource, Disposable, DisposableCollection, Path, isOSX, isWindows } from '../common';
 import { DEFAULT_WINDOW_HASH, WindowSearchParams } from '../common/window';
 import { TheiaBrowserWindowOptions, TheiaElectronWindow, TheiaElectronWindowFactory } from './theia-electron-window';
 import { ElectronMainApplicationGlobals } from './electron-main-constants';
@@ -146,9 +146,6 @@ export namespace ElectronMainProcessArgv {
     }
 }
 
-const secondaryWindowHTML = FileUri.create(path.resolve('./lib/frontend/secondary-window.html')).toString();
-console.error(`secondary url: ${secondaryWindowHTML}`);
-
 @injectable()
 export class ElectronMainApplication {
     @inject(ContributionProvider)
@@ -746,10 +743,10 @@ export class ElectronMainApplication {
                 let okToOpen = uri.scheme === 'https' || uri.scheme === 'http';
                 if (!okToOpen) {
                     const button = dialog.showMessageBoxSync(BrowserWindow.fromWebContents(webContents)!, {
-                        message: nls.localize('theia/core/openLink.message', 'Open link\n\n{0}\n\nin the system handler?', details.url),
+                        message: `Open link\n\n${details.url}\n\nin the system handler?`,
                         type: 'question',
-                        title: nls.localizeByDefault('Open Link'),
-                        buttons: [nls.localizeByDefault('OK'), nls.localizeByDefault('Cancel')],
+                        title: 'Open Link',
+                        buttons: ['OK', 'Cancel'],
                         defaultId: 1,
                         cancelId: 1
                     });