From ad81bb893d5ead462bbf64728f46d8232a7a9b63 Mon Sep 17 00:00:00 2001 From: Olaf Lessenich Date: Tue, 29 Aug 2023 11:44:50 +0200 Subject: [PATCH] fix: use more specific locators for dialog buttons in playwright tests Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich --- examples/playwright/src/tests/theia-electron-app.test.ts | 4 ++-- examples/playwright/src/tests/theia-workspace.test.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/playwright/src/tests/theia-electron-app.test.ts b/examples/playwright/src/tests/theia-electron-app.test.ts index 3d5d9e3f27b79..62b4ccb0de1c3 100644 --- a/examples/playwright/src/tests/theia-electron-app.test.ts +++ b/examples/playwright/src/tests/theia-electron-app.test.ts @@ -65,7 +65,7 @@ test.describe('Theia Electron Application', () => { await (await menuBar.openMenu('File')).clickMenuItem('Open File...'); const fileDialog = await app.page.waitForSelector('div[class="dialogBlock"]'); expect(await fileDialog.isVisible()).toBe(true); - await app.page.getByRole('button', { name: 'Cancel' }).click(); + await app.page.locator('#theia-dialog-shell').getByRole('button', { name: 'Cancel' }).click(); expect(await fileDialog.isVisible()).toBe(false); }); @@ -79,7 +79,7 @@ test.describe('Theia Electron Application', () => { const fileEntry = app.page.getByText('sample.txt'); await fileEntry.click(); - await app.page.getByRole('button', { name: 'Open' }).click(); + await app.page.locator('#theia-dialog-shell').getByRole('button', { name: 'Open' }).click(); const span = await app.page.waitForSelector('span:has-text("content line 2")'); expect(await span.isVisible()).toBe(true); diff --git a/examples/playwright/src/tests/theia-workspace.test.ts b/examples/playwright/src/tests/theia-workspace.test.ts index c6df6e72cc191..d1effde770752 100644 --- a/examples/playwright/src/tests/theia-workspace.test.ts +++ b/examples/playwright/src/tests/theia-workspace.test.ts @@ -61,7 +61,7 @@ test.describe('Theia Workspace', () => { const fileEntry = app.page.getByText('sample.txt'); await fileEntry.click(); - await app.page.getByRole('button', { name: 'Open' }).click(); + await app.page.locator('#theia-dialog-shell').getByRole('button', { name: 'Open' }).click(); const span = await app.page.waitForSelector('span:has-text("content line 2")'); expect(await span.isVisible()).toBe(true);