Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The settings.json file supports validation of settings. #14191

Open
zhouxinghong opened this issue Sep 18, 2024 · 5 comments
Open

The settings.json file supports validation of settings. #14191

zhouxinghong opened this issue Sep 18, 2024 · 5 comments

Comments

@zhouxinghong
Copy link

Feature Description:

Hello everyone!
Please support the validation of the settings in settings.json file so that the settings properties can be correctly and effectively migrated from the settings.json file of VSCode.

Theia 1.53.200
Windows 10

@msujew
Copy link
Member

msujew commented Sep 18, 2024

We already support settings.json validation:

image

@zhouxinghong What exactly are you missing?

@zhouxinghong
Copy link
Author

#13993

@zhouxinghong
Copy link
Author

zhouxinghong commented Sep 18, 2024

If some settings are invalid, then in the Problems panel in VSCode it will tell me that these settings are not recognized. However, in Theia platform, it does not tell me any error information.

Video_2024-09-18_223626.mp4

You should be able to see that I don’t have the C# extension installed, but I have defined the setting properties of the C# extension in settings.json. Theia should tell me that it is not recognized, which is in line with the correct validation logic.

@zhouxinghong
Copy link
Author

Next, please see how to verify the settings.json file setting properties in VSCode.
image
image
image

@dhuebner
Copy link
Contributor

@msujew
I think what is missing is maybe a "current installation aware" validation. In @zhouxinghong csharp is a valid Language entry but a corresponding extension is not installed. Maybe a better example is the following:

"[typescript]": {
 "editor.tabSize": 4,
 "editor.defaultFormatter": "invlaid",
},

Compared to the vs-code, in Theia there is no validation warning for "editor.defaultFormatter", also the content assist doesn't provide possible values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants