Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for newcomers to get it to compile inside Eclipse #107

Open
fabioz opened this issue Jun 11, 2017 · 6 comments
Open

Update docs for newcomers to get it to compile inside Eclipse #107

fabioz opened this issue Jun 11, 2017 · 6 comments

Comments

@fabioz
Copy link
Contributor

fabioz commented Jun 11, 2017

It'd be nice to provide instructions on where to find dependencies so that TM4E compiles cleanly after getting the sources.

I've gotten Joni, JCodings and GSON from http://download.eclipse.org/tools/orbit/R-builds/R20170516192513/repository/ but I'm still missing bundle 'org.eclipse.ui.tests.harness'.

I thought it was from Eclipse Test Framework (from http://download.eclipse.org/eclipse/updates/4.7milestones/) but I installed it and it's still not resolving... docs targeting devs on how to start developing would be nice.

Also, after getting a clean copy from github, I have 2 other errors saying that projects org.eclipse.tm4e.core.tests and org.eclipse.tm4e.ui.etsts are missing required source folder src/main/java.

@mickaelistria
Copy link
Contributor

There is a .target definition exactly for this: https://github.com/eclipse/tm4e/blob/master/target-platform/tm4e-target.target . Just open it in the IDE and click "Set as Target Platform". But indeed, it could be documented to use it.

@angelozerr
Copy link
Contributor

Any PR are welcome!

@fabioz
Copy link
Contributor Author

fabioz commented Jun 12, 2017

Ok, I did that, but now tests are still not compiling. Initial error says that the projects org.eclipse.tm4e.core.tests and org.eclipse.tm4e.ui.etsts are missing required source folder src/main/java.

missing_required_source_folder

If I just remove those from the build path, I get other compile errors too (as shown in the screenshot below).

compile_errors

So, I guess there's some other step I'm missing after setting the target platform.

p.s.: I'll create a PR after I'm able to go through what's needed myself ;)

fabioz added a commit to fabioz/tm4e that referenced this issue Jun 12, 2017
Also provide an additional .target which allows users to add TM4E to the
current running platform.

Fixes: eclipse#107

Signed-off-by: Fabio Zadrozny <[email protected]>
@amyers735
Copy link

Thanks for this - I was able to get it building by following it.

I've added a language to the samples project. How do I then build that as a plugin which I can install in another eclipse instance?

@fabioz
Copy link
Contributor Author

fabioz commented Jun 30, 2017

As a note, I still don't know how to fix the initial compile error (so, although I created a commit on my branch I still haven't created a PR because it's still incomplete).

@amyers735
Copy link

amyers735 commented Jun 30, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants