Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make app compatible with django 3 changes #24

Open
nKandel opened this issue Dec 8, 2020 · 3 comments
Open

make app compatible with django 3 changes #24

nKandel opened this issue Dec 8, 2020 · 3 comments

Comments

@nKandel
Copy link

nKandel commented Dec 8, 2020

need to update six import location in order to make it compatible with django 3.

replace from django.utils.six.moves.urllib import parse as urlparse with from six.moves.urllib import parse as urlparse at storage file

line from django 3 release page:

django.utils.six - Remove usage of this vendored library or switch to six.
@nKandel
Copy link
Author

nKandel commented Jun 29, 2024

Additional changes required for Django 4 in the storage file.

from django.utils.encoding import force_str as force_text 
from urllib.parse import quote as urlquote
from six.moves.urllib import parse as urlparse

@jacobwegner
Copy link
Contributor

Thanks @nKandel.

I think this repo is overdue to be marked as read-only.

I'll see if I can write a small migration document from this library to django-storages, which has received ongoing maintenance.

The biggest change between django-gapc-storage and django-storages with the GoogleCloudStorage backend is that the GS_FILE_OVERWRITE setting defaults to True, where the allow_overwrite setting on this project defaults to False:

https://github.com/eldarion/django-gapc-storage/blob/master/gapc_storage/storage.py#L69

I would recommend using GS_FILE_OVERWRITE=False if migrating to django-storages.

@nKandel
Copy link
Author

nKandel commented Jun 29, 2024

Hi @jacobwegner. Thank you very much for the prompt reply. A migration guideline would be a huge help. For someone who isn't familiar with the django-storages and django-gpac-storage internal codebases, it would provide the needed clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants