Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ext_authz: Added support for populating the tls_session for extensions.filters.network.ext_authz.v3.ExtAuthz #936

Closed
marc-barry opened this issue May 3, 2024 · 4 comments

Comments

@marc-barry
Copy link

In https://www.envoyproxy.io/docs/envoy/v1.30.0/version_history/v1.30/v1.30.0 and via envoyproxy/envoy#33105 there was support added for the following:

ext_authz: Added support for populating the tls_session check request attribute for network ext_authz by setting include_tls_session to true.

Is there a way I can work around the Go side not supporting that new functionality? It is documented under https://www.envoyproxy.io/docs/envoy/v1.30.0/api-v3/extensions/filters/network/ext_authz/v3/ext_authz.proto#envoy-v3-api-msg-extensions-filters-network-ext-authz-v3-extauthz. I'm trying to find out how I can effectively hack this in while we wait for the go-control-plane to catch up to the latest features of Envoy.

@sunjayBhatia
Copy link
Member

Envoy repo APIs are automatically mirrored into this repo, see:

IncludeTlsSession bool `protobuf:"varint,8,opt,name=include_tls_session,json=includeTlsSession,proto3" json:"include_tls_session,omitempty"`

@marc-barry
Copy link
Author

Envoy repo APIs are automatically mirrored into this repo, see:

@sunjayBhatia OK. I uses releases under https://github.com/envoyproxy/go-control-plane/releases/tag/v0.12.0 and so I guess I need to bypass that and pull in the latest main branch changes. Is this typically safe to do instead of waiting until a new release is made? At what cadence is a new release created?

@valerian-roche
Copy link
Contributor

We do not create releases regularly recently. There is ongoing work to split the API module to allow independent versioning in #714

@marc-barry
Copy link
Author

We do not create releases regularly recently. There is ongoing work to split the API module to allow independent versioning in #714

Thanks for the reference. I'll close this off as I have the information I need and I'll follow #714 for the topic of releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants