Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export of multi-character monomer IDs inside ambiguous monomer works wrong (RNA1{R([5eU],[Xan],[psiU])P}$$$$V2.0) #2321

Closed
AlexeyGirin opened this issue Sep 5, 2024 · 1 comment · Fixed by #2371 or #2372
Closed

Export of multi-character monomer IDs inside ambiguous monomer works wrong (RNA1{R([5eU],[Xan],[psiU])P}$$$$V2.0) #2321

AlexeyGirin opened this issue Sep 5, 2024 · 1 comment · Fixed by #2371 or #2372
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Milestone
Indigo-1.24.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Sep 5, 2024 •
edited
Loading

Steps to Reproduce

  1. Toggle to Macro - Sequence mode
  2. Load from clipboard way: RNA1{R([5eU],[Xan],[psiU])P}$$$$V2.0
    image
  3. Save canvas to HELM

Actual behavior
Export result has no square brackets for multi-character monomer IDs
image

Expected behavior
Monomers with multi-character IDs must be enclosed in square brackets “[]” - RNA1{R(5eU,Xan,psiU)P}$$$$V2.0

As per requirement:
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #2188
@AlexeyGirin AlexeyGirin added Bug Priority: High HELM Bucket: Bugs related to Export to HELM format labels Sep 5, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.24.0-rc.2 milestone Sep 5, 2024
AliaksandrDziarkach added a commit that referenced this issue Sep 13, 2024
@AliaksandrDziarkach
#2321 - Export of multi-character monomer IDs inside ambiguous monom…
1fb7bb4 
…er works wrong

Fix export. Fix UT.
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 13, 2024 that will close this issue
#2321 - Export of multi-character monomer IDs inside ambiguous monomer works wrong #2371
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Sep 13, 2024
@AliaksandrDziarkach
Backmerge: #2321 - Export of multi-character monomer IDs inside ambig…
57557df 
…uous monomer works wrong

backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 13, 2024 that will close this issue
Backmerge: #2321 - Export of multi-character monomer IDs inside ambiguous monomer works wrong #2372
Merged
4 tasks
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Sep 13, 2024
AlexanderSavelyev pushed a commit that referenced this issue Sep 13, 2024
@AliaksandrDziarkach
#2321 - Export of multi-character monomer IDs inside ambiguous monom…
3f841ab 
…er works wrong (#2371)
AlexanderSavelyev pushed a commit that referenced this issue Sep 13, 2024
@AliaksandrDziarkach
Backmerge: #2321 - Export of multi-character monomer IDs inside ambig…
e74230f 
…uous monomer works wrong (#2372)
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-09-19_12h42_16

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.3]
Indigo version
[Version 1.24.0-rc.3]

@Zhirnoff Zhirnoff mentioned this issue Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Projects
None yet
Milestone
Indigo-1.24.0-rc.3
3 participants
@AliaksandrDziarkach @AlexeyGirin @Zhirnoff