Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TestGasPriceIncrease ; Add Test Case #12189

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

axelKingsley
Copy link
Contributor

@mslipper recently changed behavior in the Tx Manager, and I realized there was an opportunity to add testing around it.

  • Added a txMod func to the existing tests, which modifies the transaction prior to increasing the gas
  • used a No-Op modification in all test cases, except for...
  • the new Test case which I added, injects inflated gas prices into the original transaction, and confirms that the original value is the one that gets used.
  • I also reorganized the other tests, as I noticed that if the increase ever fails, err is the last thing that gets checked, meaning you'll end up hitting a null pointer on the other checks first.

@axelKingsley axelKingsley requested a review from a team as a code owner September 27, 2024 21:28
@axelKingsley axelKingsley requested review from mds1 and removed request for a team September 27, 2024 21:28
Copy link
Contributor

semgrep-app bot commented Sep 27, 2024

Semgrep found 6 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

Base automatically changed from feat/sepolia-deployment to develop September 27, 2024 21:34
@circleci-checks circleci-checks bot requested review from a team as code owners September 27, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant