Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building dll for windows #277

Closed
onrdmr opened this issue Mar 13, 2024 · 4 comments
Closed

Building dll for windows #277

onrdmr opened this issue Mar 13, 2024 · 4 comments

Comments

@onrdmr
Copy link

onrdmr commented Mar 13, 2024

I have this issue i changed path to 'C:\Program Files\PostgreSQL\15' like instruction said:

Severity Code Description Project File Line Suppression State Details
Error The BaseOutputPath/OutputPath property is not set for project 'wal2json.vcxproj'. Please check to make sure that you have specified a valid combination of Configuration and Platform for this project. Configuration='Debug' Platform='x64'. This error may also appear if some other project is trying to follow a project-to-project reference to this project, this project has been unloaded or is not included in the solution, and the referencing project does not build using the same or an equivalent Configuration or Platform. wal2json C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets 832

@onrdmr onrdmr changed the title Buidling dll for windows Building dll for windows Mar 13, 2024
@eulerto
Copy link
Owner

eulerto commented Apr 25, 2024

@onrdmr Could you try again? I updated the vcxproj file to use Visual Studio 2022 and Windows 10. If you are using a different Windows version and/or Visual Studio, check the commit 7f75b33 and adjust the version.

@onrdmr
Copy link
Author

onrdmr commented Apr 25, 2024

it works well but i need to install windows 10 sdk and retarget to project to my installed sdk otherwise it gives another error.
i have created this pull request #279 for this issue

@eulerto
Copy link
Owner

eulerto commented Apr 26, 2024

Hmm. Doesn't it work if you just set WindowsTargetPlatformVersion to your current SDK? Maybe if you remove WindowsTargetPlatformVersion line, it picks the SDK that is available. You can also use a workaround. I should probably mention that: (a) the current vcxproj file uses Visual Studio 2022 and Windows 10 and (b) you should adjust it based on your build environment and operating system version.

@onrdmr
Copy link
Author

onrdmr commented Apr 27, 2024

As you have said, we don't need WindowsTargetPlatformVersion in our .vsxproj file. It is come from retarget projects on project menu as you see here visual studio 2022 ui
i have updated this pull request , #279 , from your feedback. if you wish, you can merge it.

@onrdmr onrdmr closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants