Skip to content

Latest commit

 

History

History
282 lines (209 loc) · 10.8 KB

readme.md

File metadata and controls

282 lines (209 loc) · 10.8 KB
Raw

How to use

The vk generator

  • Depends on documentation having been built in Vulkan-Docs
  • Outputs the vulkan source to a directory called out
    • I usually symlink this to ../src
  • For faster iteration documentation generation can be disabled by setting doLoadDocs to False in vk/Main.hs

To generate the docs in Vulkan-Docs, note that this requires quite a recent nixpkgs with he and escape-string-regexp (One with NixOS/nixpkgs#86773 merged):

cd Vulkan-Docs
nix-shell -p python3 python3Packages.pyparsing asciidoctor gnumake nodejs nodePackages.he nodePackages.escape-string-regexp --run "./makeAllExts refpages generated"

The vma generator

  • Depends on documentation having been built in ../VulkanMemoryAllocator/VulkanMemoryAllocator
  • Outputs the VulkanMemoryAllocator source to a directory called out-vma
    • I usually symlink this to ../VulkanMemoryAllocator/src

I usually run the generators with ghci $(HIE_BIOS_OUTPUT=/dev/stdout ./flags.sh $(pwd)/vk/Main.hs) vk/Main.hs +RTS -N16

To generate the docbook documentation required by vma:

In an environment with doxygen (nix-shell -p doxygen), in the VulkanMemoryAllocator/VulkanMemoryAllocator directory.

sed -i -e 's|^GENERATE_DOCBOOK.*|GENERATE_DOCBOOK=YES|' \
       -e 's|^BRIEF_MEMBER_DESC.*|BRIEF_MEMBER_DESC=NO|' \
       -e 's|^PREDEFINED *=|PREDEFINED = VMA_STATS_STRING_ENABLED=1 |' \
       -e 's|^PREDEFINED *=|PREDEFINED = VMA_EXTENDS_VK_STRUCT(s)=s |' \
       -e 's|@CMAKE_SOURCE_DIR@/||' \
       Doxyfile
nix-shell -p doxygen --run 'doxygen Doxyfile'

The docbook documentation will be in docs/docbook.

TODO

  • OpenXR bindings, the spec looks very similar to the vulkan spec: https://github.com/KhronosGroup/OpenXR-Docs

  • List instead of vector? Most of the arrays passed to vulkan (in my code at least) are just a single element. All of them are less than 5 or 6 elements I think. The marshaling code doesn't need O(1) random access, perhaps lists would be more convenient.

  • pay attention to noautovalidity, At the moment this is ignored, but it's a hint that there's something slightly non-standard happening.

    • Additionally anything which is returnedonly=true should never appear in a negative position

  • Neaten zero writing, we write some unnecessary zero bytes already set by calloc.

  • We sometimes use calloc where alloc would do, when passing in space for "out" parameters for instance

  • non-optional arrays/structs can be allocated at the same time as their parent struct, no need for two allocations

  • Unions should probably not use tuple when storing several values, VkClearColorValue for instance

  • Add tests to make sure that allocaEmptyCStruct peekCStruct always works, and is equal to zero.

  • Make PFN_vkVoidFunction not a FunPtr as it can't be called without casting anyway.

  • Groups of lifted actions which don't return anything can be grouped under one lift:

  • If we move to peeking and poking ByteArrays using RecordDotSyntax it would be nice to have alternative virtual members for using nicer types than tuples for vectors and matricies. For example it would be nice to use linears Mat34 to set VkAccelerationStructureInstanceKHR::transform.

  • Don't peek the same value for every bitfield component

  • Use selection and selector attributes in the xml to generate the UnionDiscriminator table automatically.

  • Replace Aabbs with AABBs

  • Elide union tag

Video:

  • Parse header files (this is already done for VMA, so the code is more or less written)
  • Integrate these definitions in parseSpec

The complication is that lots of the structs there use bitfields, so proper support for them needs to be done...

At the moment the extensions are disabled in Bespoke.hs

To check

During development unfinished bits not to forget are listed here.

  • src/Vulkan/Core10/Pipeline.hs attachmentCount, is the optional marking here correct?

OpenXR

  • Handle levels

    • They are all "session"

  • Bespoke vulkan types should be just in sizes

  • Remove vulkan stuff from bespokeSizes

    • Would be nice to generate it automatically, but it's fine as it is

  • Fix runAsciidoctor

  • These are passed as pointers ,(see Bespoke.MarshalParams.isPassAsPointerType')

    • VkInstanceCreateInfo, VkAllocationCallbacks, VkDeviceCreateInfo
    • LARGE_INTEGER
    • timespec

  • remove XR.RenderParams.vulkanNameOverrides

  • check

    • XrCompositionLayerBaseHeader (the 'type' member doesn't have a single value)
    • XrEventDataBuffer->varying
    • XrSpatialGraphNodeSpaceCreateInfoMSFT->nodeId
    • XrSpatialGraphNodeSpaceCreateInfoMSFT
    • XrEventDataBuffer
    • xrCreateInstance: Unable to find ref named cmds
    • xrResultToString: Unhandled ByteString conversion to Ptr NonConst Char
    • xrStructureTypeToString: Unhandled ByteString conversion to Ptr NonConst Char
    • xrPathToString: Getting the unpreserved haskell type for char. This case should be implemented if this char is not better represented by a bytestring
    • xrCreateSwapchainAndroidSurfaceKHR: Unable to get size for TypeName jobject
    • xrGetInputSourceLocalizedName: Getting the unpreserved haskell type for char. This case should be implemented if this char is not better represented by a bytestring
    • xrGetVulkanInstanceExtensionsKHR: Getting the unpreserved haskell type for char. This case should be implemented if this char is not better represented by a bytestring
    • xrGetVulkanDeviceExtensionsKHR: Getting the unpreserved haskell type for char. This case should be implemented if this char is not better represented by a bytestring
    • xrCreateVulkanInstanceKHR: Unable to get size for TypeName VkResult
    • xrCreateVulkanDeviceKHR: Unable to get size for TypeName VkResult
    • xrCreateSpatialAnchorFromPerceptionAnchorMSFT: Unable to get size for TypeName IUnknown

  • Check we have all of

    • NULL_SYSTEM_ID
    • NULL_PATH
    • SUCCEEDED
    • FAILED
    • UNQUALIFIED_SUCCESS
    • NO_DURATION
    • INFINITE_DURATION
    • MIN_HAPTIC_DURATION
    • FREQUENCY_UNSPECIFIED
    • MAX_EVENT_DATA_SIZE
    • MAY_ALIAS
      • no need

  • Make Vulkan integration optional, have a module which either defines opaque handles or reexports types from vulkan

  • make Xr stuff in bespokeModules

  • dual-use commands have a different style in OpenXR... they're wrong now

    • xrEnumerateApiLayerProperties
    • xrEnumerateInstanceExtensionProperties
    • xrEnumerateSwapchainFormats
    • xrEnumerateReferenceSpaces
    • xrEnumerateViewConfigurations
    • xrEnumerateEnvironmentBlendModes
    • xrEnumerateViewConfigurationViews
    • xrLocateViews
    • xrPathToString
    • xrEnumerateBoundSourcesForAction
    • xrGetInputSourceLocalizedName
    • xrGetVulkanInstanceExtensionsKHR
    • xrGetVulkanDeviceExtensionsKHR
    • xrLoadControllerModelMSFT
      • Should return a bytestring or storable vector
    • xrEnumerateDisplayRefreshRatesFB
    • xrEnumerateColorSpacesFB

  • Implement OpenXR's polymorphic types

  • change \CFloat a -> a to coerce @CFloat @Float

  • Put modules under OpenXR instead of Vulkan

  • OpenXR brackets

  • Remove uses of WildCardT

  • Remove or improve special handling for CompositionLayerBaseHeader

  • Remove or improve special handling for enumerateSwapchainImages

  • Remove uses of schemeTypeNegativeWithContext in Render.Command (there are TODOs) in the code.

  • Some structs have an in-out purpose, see https://www.khronos.org/registry/OpenXR/specs/1.0/html/xrspec.html#buffer-size-parameters

    • affects at least xrGetVisibilityMaskKHR and a few extension functions.
    • Look at every use of "CapacityInput" or "CountOutput"

  • Fix or remove XR_EXT_conformance_automation

    • Annoying to fix because it passes structs by value so would need a C shim

  • Expose XR_CURRENT_API_VERSION

  • Auto update functionality for OpenXR

1.2.162

  • optionalness on VkWriteDescriptorSetAccelerationStructureKHR->pAccelerationStructures
  • VkAccelerationStructureVersionKHR
  • VkAccelerationStructureInstanceKHR
  • VkAccelerationStructureBuildGeometryInfoKHR
  • VkAccelerationStructureBuildGeometryInfoKHR->pGeometries (esp optionalness)
  • VkAccelerationStructureBuildGeometryInfoKHR->ppGeometries (esp optionalness)
    • (this maps to the same name as pGeometries!)
    • This has been removed from the Haskell bindings
  • VkAccelerationStructureCreateInfoKHR->offset
  • VkAccelerationStructureVersionInfoKHR->pVersionData
  • vkCmdBuildAccelerationStructuresIndirectKHR,
    • The Ptr Word32 type has leaked through, this should be Vector (Vector Word32)
    • Fix this non-critical issue
    • It's correct now, but it doesn't check the length of the array
  • vkCmdBuildAccelerationStructuresKHR, vkBuildAccelerationStructuresKHR
    • This is still incorrect as one can't pass multiple AccelerationStructureBuildRangeInfoKHR's per AccelerationStructureBuildGeometryInfoKHR. It's no more broken than before though.
    • Fixed, although there's no length checking
  • vkGetAccelerationStructureBuildSizesKHR
    • It's correct, but it doesn't check the length of the maxPrimitiveCount array like it would with a sibling array of same length
  • pNext is now optional, this breaks the Zero instances

Optional TODOs:

  • cmdTraceRaysKHR is not using the storable instance of StridedDeviceAddressRegionKHR
    • same for destroyAccelerationStructureKHR not using allocation callbacks
    • These are due to the indirectStruct case of the normal poker
    • This is no problem, commands have to allocate structs on the stack anyway
  • likewise for pokeCStruct of RayTracingPipelineCreateInfoKHR{..}
    • This one is because we're not looking past pointers when checking for direct dependents
    • Fixed
  • Documentation on bracketing functions still mentions the "first" argument, this should be chagned to "last"
  • AccelerationStructureGeometryAabbsDataKHR could use a simple poke for its DeviceOrHostAddressConstKHR (is this true for the union in AccelerationStructureGeometryKHR too)
  • Now is the time to remove the top level tuple from TransformMatrixKHR

1.3.204

  • Check VkPhysicalDeviceShaderDemoteToHelperInvocationFeaturesEXT
  • VkPhysicalDeviceShaderIntegerDotProductFeaturesKHR

VMA TODOs

TODO

  • Make buildStatsString return a ByteString
  • pHeapSizeLimit length
  • VmaDefragmentationPassInfo::pMoves

More bindings to make

  • chaoticbob/SPIRV-Reflect

  • ValveSoftware/openvr

  • cgltf