From 2d4dfef28139807d5bff5b58f0b333cca4392b16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20de=20Kok?= Date: Tue, 2 Apr 2024 14:03:49 +0200 Subject: [PATCH] Adjust two cross-tests for changes in HF transformers (#367) * Fix `test_rotary_embeddings_against_hf` for latest transformers * xfail test because HfFileSystem is currently broken --- curated_transformers/tests/layers/test_embeddings.py | 3 ++- curated_transformers/tests/tokenizers/test_hf_hub.py | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/curated_transformers/tests/layers/test_embeddings.py b/curated_transformers/tests/layers/test_embeddings.py index 085db7ad..8e741110 100644 --- a/curated_transformers/tests/layers/test_embeddings.py +++ b/curated_transformers/tests/layers/test_embeddings.py @@ -24,7 +24,8 @@ def test_rotary_embeddings_against_hf(device): X = torch.rand(16, 12, 64, 768, device=device) Y = re(X) - hf_re_cos, hf_re_sin = hf_re(X, seq_len=X.shape[-2]) + positions = torch.arange(X.shape[2], device=device).view([1, -1]) + hf_re_cos, hf_re_sin = hf_re(X, positions) Y_hf = hf_re_cos * X + hf_re_sin * rotate_half(X) torch_assertclose(Y, Y_hf) diff --git a/curated_transformers/tests/tokenizers/test_hf_hub.py b/curated_transformers/tests/tokenizers/test_hf_hub.py index 183145e4..b6859dce 100644 --- a/curated_transformers/tests/tokenizers/test_hf_hub.py +++ b/curated_transformers/tests/tokenizers/test_hf_hub.py @@ -51,6 +51,7 @@ def test_from_hf_hub_to_cache_legacy(): ) +@pytest.mark.xfail(reason="HfFileSystem calls safetensors with incorrect arguments") @pytest.mark.skipif(not has_hf_transformers, reason="requires huggingface transformers") def test_fsspec(sample_texts): # We only test one model, since using fsspec downloads the model