Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register models/tokenizers through catalogue, so that the auto classes pick them up #346

Closed
danieldk opened this issue Oct 3, 2023 · 2 comments
Closed

Register models/tokenizers through catalogue, so that the auto classes pick them up #346

danieldk opened this issue Oct 3, 2023 · 2 comments
Labels
feat/model Feature: models feat/tokenization Feature: Tokenization/piecer type/feature Type: Feature
Milestone
v2.0.0

Comments

@danieldk
Copy link
Contributor

danieldk commented Oct 3, 2023

The auto classes can currently support tokenizers and models from Curated Transformers. If they were registered through catalogue, we could support external models in the auto classes.
@danieldk danieldk added type/feature Type: Feature feat/model Feature: models feat/tokenization Feature: Tokenization/piecer labels Oct 3, 2023
@danieldk danieldk added this to the v2.0.0 milestone Oct 3, 2023
@danieldk danieldk mentioned this issue Oct 3, 2023
Open
@Ryu1845
Copy link

Ryu1845 commented Mar 26, 2024

Shouldn't this be closed, considering #351 ?

@danieldk
Copy link
Contributor Author

I think we kept this open because we still want to move Falcon to an extras package. But that's also covered by #347. So yeah, let's close this one 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat/model Feature: models feat/tokenization Feature: Tokenization/piecer type/feature Type: Feature
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@danieldk @Ryu1845