Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register simple function should not consider result type #10602

Open
jinchengchenghh opened this issue Jul 30, 2024 · 1 comment · May be fixed by #10811
Open

Register simple function should not consider result type #10602

jinchengchenghh opened this issue Jul 30, 2024 · 1 comment · May be fixed by #10811
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@jinchengchenghh
Copy link
Contributor

jinchengchenghh commented Jul 30, 2024

Bug description

When we register function with same input type and function name while overwrite is true, it should not consider resultType, but now, it cannot overwrite because integer variables is different in FunctionSignature.
#10467 (comment)
#10467 (comment)

System information

Velox System Info v0.0.2
Commit: 76c5795
CMake Version: 3.28.3
System: Linux-5.4.0-190-generic
Arch: x86_64
C++ Compiler: /usr/bin/c++
C++ Compiler Version: 9.4.0
C Compiler: /usr/bin/cc
C Compiler Version: 9.4.0
CMake Prefix Path: /usr/local;/usr;/;/usr/local/lib/python3.8/dist-packages/cmake/data;/usr/local;/usr/X11R6;/usr/pkg;/opt

@jinchengchenghh jinchengchenghh added bug Something isn't working triage Newly created issue that needs attention. labels Jul 30, 2024
@jinchengchenghh
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Newly created issue that needs attention.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant