Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Fastlane 2.137 #31

Open
jake-fooda opened this issue Dec 16, 2019 · 12 comments
Open

Incompatible with Fastlane 2.137 #31

jake-fooda opened this issue Dec 16, 2019 · 12 comments
Assignees

Comments

@jake-fooda
Copy link

Inheriting Faraday::Error::ClientError is deprecated; use Faraday::ClientError instead. It will be removed in or after version 1.0
Faraday::Error::ClientError.inherited called from /Users/me/.rvm/gems/ruby-2.3.1/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14.

We're seeing errors running danger-xcov with the latest version of fastlane. Any help with what we're doing wrong would be great. Thanks!

We're using versions:
fastlane 2.137.0
danger 6.1.0
danger-xcov 0.4.1
faraday 0.17.1
octokit 4.14.0
xcov 1.7.0

@joshdholtz joshdholtz self-assigned this Dec 16, 2019
@joshdholtz
Copy link
Member

Will look into tomorrow or Wednesday! Thanks for posting all your gem versions 😊❤️

@jake-fooda
Copy link
Author

awesome, thank you!

@Kaspik
Copy link

Kaspik commented Apr 21, 2020

@joshdholtz Any update on this? Or any other PR that is opened please?

@joshdholtz
Copy link
Member

@Kaspik On it now! Won’t leave my desk until merged and released. Thanks for ping ❤️

@Kaspik
Copy link

Kaspik commented Apr 21, 2020

Thaaank ya!

@Kaspik
Copy link

Kaspik commented Apr 22, 2020

@joshdholtz Seems like this didn't go as expected... :) Anything we can help with?

@joshdholtz
Copy link
Member

@Kaspik My apologies! Needed to get a new version of fastlane out and prepping for a talk/presentation today took longer than expected. Still have the tab open to get to as soon as I can 🙏

@Kaspik
Copy link

Kaspik commented Apr 22, 2020

@joshdholtz It seems like there is more issues. This uses older xcov, and it's way older so it can't get results from XCode 11 build.

Running on the same code (workspace) xcov (latest) works where running this Danger plugin reports Unable to find any .xccoverage file..

@joshdholtz
Copy link
Member

@jake-fooda Are you able to upgrade to Ruby 2.4 at all? Ruby 2.4 has some major security updates to it and a lot of the dependencies that fastlane uses are requiring Ruby 2.4. There are things within the we are trying to do within fastlane to still support older versions of Ruby but its getting harder and harder.

If you could let me know if you could update to Ruby 2.4 and if that works that would be great!

@joshdholtz
Copy link
Member

@Kaspik Are you also running something older than Ruby 2.4? 🤔

@Kaspik
Copy link

Kaspik commented Apr 26, 2020

I’m running 2.7.1 already :)

@Kaspik
Copy link

Kaspik commented Apr 26, 2020

@joshdholtz I believe my issue is different than this one at the end, and I described that here: #30

We basically need to update this library to latest XCov to support XCode 11 so we don§t have to do in-between steps. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants