Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate iPhone notification and Spotlight icons #34

Open
RishabhTayal opened this issue Mar 24, 2018 · 2 comments
Open

Generate iPhone notification and Spotlight icons #34

RishabhTayal opened this issue Mar 24, 2018 · 2 comments
Labels
enhancement

Comments

@RishabhTayal
Copy link
Contributor

Does the plugin generate the iPhone notification and Spotlight icons? From the source code I don't think it does. Just want to confirm.

If not, I would be happy to implement this and create a PR. LMK. 👍
@felipeplets
Copy link
Collaborator

Hello RishabhTayal,

I've checked Apple documentation on icons https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/ and can confirm we don't have it generated by our plugin.

You are welcome to create the PR and I will be happy reviewing it.

All the best,
Felipe

@RishabhTayal
Copy link
Contributor Author

@felipeplets I see there is already some code for custom size icons? Is that related? Are we using that already?

https://github.com/KrauseFx/fastlane-plugin-appicon/blob/2875d8c24c5d9af5f011bb973d767a622e80cc4f/lib/fastlane/plugin/appicon/helper/appicon_helper.rb#L39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felipeplets @RishabhTayal