Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Featrure] Support generating URL keys for same-name products #21

Open
amenk opened this issue Apr 13, 2018 · 4 comments
Open

[Featrure] Support generating URL keys for same-name products #21

amenk opened this issue Apr 13, 2018 · 4 comments

Comments

@amenk
Copy link

amenk commented Apr 13, 2018

Problem:

If you import two products with the same name, such as "T-Shirt" and one is "L", one is "M" - you have to specify the URL key manually.
If would be nice to add a -SKU or something like that to the URL key.

References:

https://magento.stackexchange.com/questions/213036/url-was-already-generated-for-an-item-with-sku-error
magento/magento2#1471 (comment)

@amenk
Copy link
Author

amenk commented Aug 17, 2018

Should we fix that here?

@amenk
Copy link
Author

amenk commented Oct 4, 2018

anybody ? Don't even know how to fix it :-(

@amenk
Copy link
Author

amenk commented Oct 10, 2018

Found out it's already fixed at HoNl's module:
https://github.com/ho-nl/magento2-Ho_Import/blob/master/src/RowModifier/ProductUrlKey.php

"Paul Hachmang [14:21 Uhr]
We have a few things to handle duplicate URL keys:
RowModifier to just append -1, -2, -3 to the URL https://github.com/ho-nl/magento2-Ho_Import/blob/master/src/RowModifier/ProductUrlKey.php (bearbeitet)"

"And two, for the creation of configurable products we have a completely custom URL builder that allows to to program exactly how the configurable/simple URL keys should work: https://github.com/ho-nl/magento2-Ho_Import/blob/master/src/RowModifier/ConfigurableBuilder.php"

Still the question @avstudnitz if this would be in scope of ExtendedImport2 or if we should create a totally seperate module?

@avstudnitz
Copy link
Member

Yes, I think it would be good in this module. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants