Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pub.dev score is about to drop #1972

Closed
monsieurtanuki opened this issue Sep 27, 2024 · 1 comment
Closed

[BUG] pub.dev score is about to drop #1972

monsieurtanuki opened this issue Sep 27, 2024 · 1 comment
Labels
bug This issue reports broken functionality or another error invalid This bug could not be reproduced or does not exist, or is very low quality S: docs Scoped to the external documentation

Comments

@monsieurtanuki
Copy link
Contributor

What is the bug?

Having a look at https://pub.dev/packages/flutter_map/score, we see that though the score is maximum (160), there are pending issues that will decrease the score.

  • Follow Dart file conventions - 10/10 points: Provide a valid pubspec.yaml
    Issue tracker URL doesn't exist.
    At the time of the analysis https://github.com/fleaflet/flutter_map/issues was unreachable. Make sure that the website is reachable via HEAD requests.
  • Platform support: 0/0 points: WASM compatibility
    This package is not compatible with runtime wasm, and will not be rewarded full points in a future version of the scoring model.
    See https://dart.dev/web/wasm for details.

How can we reproduce it?

Just go to https://pub.dev/packages/flutter_map/score

Do you have a potential solution?

No response

Platforms

Whatever

Severity

Minimum: Allows normal functioning

@monsieurtanuki monsieurtanuki added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Sep 27, 2024
@JaffaKetchup
Copy link
Member

Follow Dart file conventions - 10/10 points: Provide a valid pubspec.yaml (Issue tracker URL doesn't exist)

pana still assigns all the necessary points. I'm not sure why it doesn't detect it as a valid URL, whether it's GitHub refusing the requests from pub.dev for whatever reason (or whatever domain is running pana), or pana is broken. I might make an issue report to pana, as I've seen this before.

Platform support: 0/0 points: WASM compatibility

This appears to be because we depend on https://pub.dev/packages/logger, which pana decides isn't Wasm compatible because it imports dart:io in a specific library. But due to platform dependent imports, this doesn't actually make it Wasm incompatible. The only solution here is for pana to get better at detection with these platform dependent import situations (which is also why packages manually define supported platforms, otherwise it would say we're not compatible with Web) (which I suppose is difficult to do statically?), or give us an option to label the package Wasm ready ourselves. See dart-lang/pana#1324 & dart-lang/pub-dev#6785.

Thanks for reporting this, I'm trying to keep an eye on it in general (dart-lang/pub-dev#6785 (comment)).

@JaffaKetchup JaffaKetchup closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2024
@JaffaKetchup JaffaKetchup added invalid This bug could not be reproduced or does not exist, or is very low quality S: docs Scoped to the external documentation and removed needs triage This new bug report needs reproducing and prioritizing labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error invalid This bug could not be reproduced or does not exist, or is very low quality S: docs Scoped to the external documentation
Projects
Status: Done
Development

No branches or pull requests

2 participants