Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is there a bulk text match API? #107

Open
goneall opened this issue Aug 4, 2023 · 7 comments
Open

Question: Is there a bulk text match API? #107

goneall opened this issue Aug 4, 2023 · 7 comments

Comments

@goneall
Copy link

goneall commented Aug 4, 2023

I'm working on migrating an app from using fossdriver to this fossology-python.

I've worked out most of the mapping with the exception of the bulk text match described here.

Is there an equivalent function in this library or API? If not, any advice on how to migrate that feature over?

@deveaud-m
Copy link
Collaborator

Hi @goneall,

From my understanding of the BulkTextMatch workflow it is meant to interact with scan results and license matches, right?

Unfortunately there is no Rest API endpoints able to perform such tasks (as far as I know). Maybe this needs to be discussed first in Fossology, e.g. in this issue about evolution of the REST API.

/cc @shaheemazmalmmd

@goneall
Copy link
Author

goneall commented Aug 4, 2023

Thanks @deveaud-m for the quick response.

From my understanding of the BulkTextMatch workflow it is meant to interact with scan results and license matches, right?

That is my understanding as well. This is used in a batch mode in the Linux Foundation Scaffold script and is driven by configuration files. In looking at the fossdriver implementation, it is doing a post to .../repo/?mod=change-license-bulk which doesn't have a corresponding API as far as I can tell.

@GMishx
Copy link
Member

GMishx commented Aug 9, 2023

Hey @goneall and @deveaud-m , the endpoints for bulk scans have recently been merged.

You can find the relevant PRs linked in the issue fossology/fossology#2472

The next version of FOSSology will be shipping with these new endpoints.

@goneall
Copy link
Author

goneall commented Aug 9, 2023

the endpoints for bulk scans have recently been merged.

Thanks @GMishx - Looks like one more PR to merge then we'll have what we need to replace the FOSSDriver implementation.

@deveaud-m - let me know if you'd like a PR to add once we have a release candidate for the next release of FOSSOlogy. Python isn't my "native" language, but I can make an attempt at a PR if it helps.

@deveaud-m
Copy link
Collaborator

@deveaud-m - let me know if you'd like a PR to add once we have a release candidate for the next release of FOSSOlogy. Python isn't my "native" language, but I can make an attempt at a PR if it helps.

I just released a new version supporting Fossology 4.2.1 today and there are still some endpoints not yet supported in this library for Fossology version 4.3.0 (see #52).

I'm a bit late but this is not a blocker, we can start working on integrating all the license clearing endpoints even if there are not released in Fossology yet so feel free to open a PR (note that I'll be on vacation until end of the month).

@deveaud-m
Copy link
Collaborator

@goneall does this endpoint provides the functionality you need: https://fossology.github.io/fossology-python/items.html#fossology.items.Items.schedule_bulk_scan?

@goneall
Copy link
Author

goneall commented Feb 15, 2024

@goneall does this endpoint provides the functionality you need: https://fossology.github.io/fossology-python/items.html#fossology.items.Items.schedule_bulk_scan?

Yes - this should work. Thanks @deveaud-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants