-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate_response
implementation is problematic?
#1
Comments
After digging further I realized my modem is using --- a/quectel-timesync.c
+++ b/quectel-timesync.c
@@ -105,6 +105,9 @@ int read_response(int fd, const char *response, char *buf, int buf_size)
break;
case READ_STATE_CONTENT:
if (input_char == '\n') {
+ if (*(ptr - 1) == '\r')
+ ptr--;
+
*ptr = '\0';
return ptr - buf;
} else { |
@szescxz I'll look info this. Can you tell me which modem you are seeing this behavior on? |
RM520N-GL, works if applied the patch above. Although I'll need to ensure |
I think we have the same modem around. I'll check. |
herbetom
added a commit
to herbetom/quectel-timesync
that referenced
this issue
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested with commit 4333888 on
aarch64
, applied a small patch to see what's going on:Result:
The text was updated successfully, but these errors were encountered: