Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting escapcahr and quotechar to double quote acts unexpected #31

Closed
zelima opened this issue Feb 14, 2018 · 1 comment
Closed

Setting escapcahr and quotechar to double quote acts unexpected #31

zelima opened this issue Feb 14, 2018 · 1 comment
Assignees

Comments

@zelima
Copy link
Contributor

zelima commented Feb 14, 2018

@anuveyatsu what is the reason using double quotes as escapechar, besides csv-parser using it as default? 398235d

Cause in python by default it's None https://docs.python.org/2/library/csv.html#csv.Dialect.escapechar

Cause it acts really weird if both, escapechar and quotechar are set to ". Eg take a look at this validation report: https://pkgstore.datahub.io/81429cbbddcfb180f54c142fac32f83b/schema/validation_report/data/874d49bd554630f5b536216ce390d4d9/validation_report.json
It thinks that everything after "{\"one\"... is one column. Same will happen even if it's quoted in a simple way, like "one, two"

I've just deleted that line from data.js and pushed, it's processed successfully https://datahub.io/zelima/schema/v/20

Do you think we can remove it?

Ans from @anuveyatsu

@zelima the reason IMO is that it is very common, e.g., go to google spreadsheet create a table with in values. Then export it as CSV and you’d see that ” was used as the escape char. I haven’t tried the same operation with Excel, but read in the web that it is the same.

Update

So think we don't really need to define it (and especially hardcode it to be ").

@zelima zelima self-assigned this Feb 14, 2018
@zelima zelima added this to the Sprint - 26 Feb 2018 milestone Feb 14, 2018
@zelima zelima mentioned this issue Feb 14, 2018
2 tasks
@zelima
Copy link
Contributor Author

zelima commented Feb 14, 2018

FIXED. We allow guessing the escapechar to the processing libraries (tabulator) in python for now. Issue for guessing it here #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant