Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization code fragments for fxos-components/fxos-text-input have confusing mix of syntax #19

Open
anaran opened this issue Mar 18, 2016 · 0 comments

Comments

@anaran
Copy link

anaran commented Mar 18, 2016

See:

https://github.com/fxos-components/fxos-text-input#localization

Details:

// If using .l20n format:
<FXOSTextInputClear ariaLabel: "Clear">

Above seems to be an HTML sample.
JavaScript comment and property syntax seems misleading, possibly incorrect.

// If using .properties format:
FXOSTextInputClear.ariaLabel = Clear

Above seems to be a JavaScript sample. Missing context of what Clear might be and the missing ; makes it hard to reason about meaning and correctness of this sample.

http://mzl.la/1vxCDgA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant