Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Ensure graphql options are correct when preloading #13769

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 24, 2024

Noticed this by chance, due to the way generateInstrumentOnce works, we need to pass in the fully formed config.

Noticed this by chance, due to the way `generateInstrumentOnce` works, we need to pass in the fully formed config.
@mydea mydea self-assigned this Sep 24, 2024
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.63 KB - -
@sentry/browser - with treeshaking flags 21.42 KB - -
@sentry/browser (incl. Tracing) 34.86 KB - -
@sentry/browser (incl. Tracing, Replay) 71.36 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.79 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.71 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.48 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.36 KB - -
@sentry/browser (incl. metrics) 26.91 KB - -
@sentry/browser (incl. Feedback) 39.77 KB - -
@sentry/browser (incl. sendFeedback) 27.29 KB - -
@sentry/browser (incl. FeedbackAsync) 32.08 KB - -
@sentry/react 25.38 KB - -
@sentry/react (incl. Tracing) 37.84 KB - -
@sentry/vue 26.8 KB - -
@sentry/vue (incl. Tracing) 36.75 KB - -
@sentry/svelte 22.76 KB - -
CDN Bundle 23.94 KB - -
CDN Bundle (incl. Tracing) 36.63 KB - -
CDN Bundle (incl. Tracing, Replay) 71.13 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.44 KB - -
CDN Bundle - uncompressed 70.14 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.6 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.48 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.69 KB - -
@sentry/nextjs (client) 37.8 KB - -
@sentry/sveltekit (client) 35.43 KB - -
@sentry/node 124.94 KB +0.02% +16 B 🔺
@sentry/node - without tracing 93.57 KB +0.01% +2 B 🔺
@sentry/aws-serverless 103.28 KB -0.01% -1 B 🔽

View base workflow run

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a test for this as well! Can just be a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants