Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_scoring method #59

Open
kxk302 opened this issue Apr 13, 2021 · 1 comment
Open

Fix get_scoring method #59

kxk302 opened this issue Apr 13, 2021 · 1 comment

Comments

@kxk302
Copy link
Contributor

kxk302 commented Apr 13, 2021

Currently, get_scoring() in galaxy_ml/utils.py assumes 'secondary_scoring' is a comma separated string. It seems galaxy now provides a list instead. Must revise get_scoring() so it can handle a list and a string (for backward compatibility). Right now, the fix (list to comma separated string conversion) happens in galaxytools. After get_scoring is revised, the fix in galaxytools should be removed.
@kxk302 kxk302 mentioned this issue Apr 13, 2021
Open
@qiagu
Copy link
Collaborator

qiagu commented Apr 13, 2021

Agreed. Now we have a something to track. Thanks for making this!

kxk302 pushed a commit to kxk302/Galaxy-ML that referenced this issue Apr 20, 2021
Fix get_scoring method (issue goeckslab#59)
914953e
@kxk302 kxk302 mentioned this issue Apr 20, 2021
Merged
4 tasks
qiagu added a commit that referenced this issue Apr 30, 2021
@qiagu
Merge pull request #60 from kxk302/get_scoring
a8561b4 
Fix get_scoring method (issue #59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kxk302 @qiagu