Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice to upgrade proctor CLI when out of date #55

Open
olttwa opened this issue Nov 22, 2018 · 4 comments
Open

Notice to upgrade proctor CLI when out of date #55

olttwa opened this issue Nov 22, 2018 · 4 comments

Comments

@olttwa
Copy link
Member

olttwa commented Nov 22, 2018

As an admin,
I want to notify users when new version is available whenever they run proctor version

Example:

$terraform version
Terraform v0.11.7

Your version of Terraform is out of date! The latest version
is 0.11.10. You can update by downloading from www.terraform.io/downloads.html

@RajatVaryani
Copy link
Contributor

@olttwa Can I pick this up?

@olttwa
Copy link
Member Author

olttwa commented Feb 8, 2019

@RajatVaryani currently there's an implementation on the server side to have a forceful upgrade of client. You can check that here

For above feature, how are you thinking to implement it?

If I were to implement it, I'd fetch the releases from github, and if current version is lower, display a message as:

Your version of Proctor client is out of date! The latest version
is 0.5.0. You can update by either running `brew upgrade proctor` or downloading a release for your OS here: https://github.com/gojektech/proctor/releases

@RajatVaryani
Copy link
Contributor

@olttwa I had the same approach. See the tag name of the latest release using https://api.github.com/repos/gojektech/proctor/releases/latest if that doesn't match show the message.

@olttwa
Copy link
Member Author

olttwa commented Feb 9, 2019

@RajatVaryani seems like a good approach. Please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants