Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the code in read annotation file in GeneOntology #36

Open
noamteyssier opened this issue Jun 28, 2022 · 1 comment
Open

Clean up the code in read annotation file in GeneOntology #36

noamteyssier opened this issue Jun 28, 2022 · 1 comment
Labels
API Improvements or additions to the API documentation Improvements or additions to documentation Testing Write up a test

Comments

@noamteyssier
Copy link
Collaborator

This method is fairly large and uncommented.
Could be split up into a few different methods or wrapped into a separate class to streamline GeneOntology

We should also write explicit tests for gzip/txt (since I found a bug in the gzip IO section) (fixed in 8141962)
@noamteyssier noamteyssier added documentation Improvements or additions to documentation API Improvements or additions to the API Testing Write up a test labels Jun 28, 2022
@noamteyssier noamteyssier mentioned this issue Jun 28, 2022
Closed
@noamteyssier
Copy link
Collaborator Author

added an explicit test for this in 62e2c2e

@noamteyssier noamteyssier mentioned this issue Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Improvements or additions to the API documentation Improvements or additions to documentation Testing Write up a test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noamteyssier