-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support no-op personality(2)
bits
#10756
Labels
type: enhancement
New feature or request
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Aug 20, 2024
This PR implements the [`personality(2)` syscall](https://www.man7.org/linux/man-pages/man2/personality.2.html) for personality bits that are no-ops on Linux. Fixes #10756. FUTURE_COPYBARA_INTEGRATE_REVIEW=#10757 from EtiennePerot:linux-is-not-a-personality-trait 91d3665 PiperOrigin-RevId: 665427818
copybara-service bot
pushed a commit
that referenced
this issue
Aug 20, 2024
This PR implements the [`personality(2)` syscall](https://www.man7.org/linux/man-pages/man2/personality.2.html) for personality bits that are no-ops on Linux. Fixes #10756. FUTURE_COPYBARA_INTEGRATE_REVIEW=#10757 from EtiennePerot:linux-is-not-a-personality-trait 91d3665 PiperOrigin-RevId: 665427818
copybara-service bot
pushed a commit
that referenced
this issue
Aug 20, 2024
This PR implements the [`personality(2)` syscall](https://www.man7.org/linux/man-pages/man2/personality.2.html) for personality bits that are no-ops on Linux. Fixes #10756. FUTURE_COPYBARA_INTEGRATE_REVIEW=#10757 from EtiennePerot:linux-is-not-a-personality-trait 91d3665 PiperOrigin-RevId: 665427818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The
personality(2)
system call is a set of per-task bits that influence task behavior. Most modern Linux applications do not use it as far as I can tell (otherwise I'd expect this system call would have come up before), but PulseAudio does. As part of its core library, it prints a user-visible warning in its logs when it fails:The
PER_LINUX
personality is the default personality on Linux, so this is effectively a no-op on Linux. Therefore it should be harmless to have it behave the same way on gVisor: let it be a no-op. (Currently, it fails withEINVAL
.)Is this feature related to a specific bug?
No
Do you have a specific solution in mind?
gVisor should allow no-op personality bits to be set on tasks, and preserve its current behavior (
EINVAL
) for other personality bits.The text was updated successfully, but these errors were encountered: