Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating qkv after padding #16

Open
shan18 opened this issue Apr 17, 2024 · 1 comment
Open

Updating qkv after padding #16

shan18 opened this issue Apr 17, 2024 · 1 comment
Assignees
@andreaskoepf

Comments

@shan18
Copy link

shan18 commented Apr 17, 2024

Hi,

In this block, the query, key, and value are being updated via _upad_input. Then in line 658, shouldn't the qkv be packed again?

https://github.com/cuda-mode/ring-attention/blob/d7aa7799bcc0191994d369b8cdebc7aebe1566b9/ring-llama/modeling_llama.py#L647-L664
@Iron-Bound
Copy link
Collaborator

@andreaskoepf could we get your advice on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreaskoepf andreaskoepf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Iron-Bound @andreaskoepf @shan18