Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data from several slices should be merged, not appended. #21

Open
Civil opened this issue Jan 19, 2015 · 2 comments
Open

Data from several slices should be merged, not appended. #21

Civil opened this issue Jan 19, 2015 · 2 comments

Comments

@Civil
Copy link

Civil commented Jan 19, 2015

If for some reasons you have situation when you have overlapping slices, reading data from the interval that matched one of them, will result in more points, then it should be there.

For example - you have some metric that due to broken merge/rollup got into this shape for the interval 1404000000 - 1412640000:

[email protected] with 100 points in it (up to 1412640000)

[email protected] with 100 points in it (up to 1414454400)

If you'll try to read the data from 1404000000 to 1412640000, you'll get in result 104 points (100 from [email protected] and 4 approximated points from [email protected] appended to the end).

I understand that it shouldn't happen, but right now there is no way to fix this situation (except to remove wrong data by hands/script), but I think that it should be handled by ceres.

@Civil
Copy link
Author

Civil commented Feb 11, 2015

Should be mostly solved by this commit (against dkulikovsky's fork):
vladimir-smirnov-sociomantic@5d1b742

@Civil
Copy link
Author

Civil commented Feb 11, 2015

(Sorry no tests for that yet, currently I don't have time to create proper test for that, but at least steps to reproduce the issue are in this ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants