Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement non-deprecated API's of Coercing #131

Open
lenin-jaganathan opened this issue Mar 5, 2024 · 1 comment
Open

Implement non-deprecated API's of Coercing #131

lenin-jaganathan opened this issue Mar 5, 2024 · 1 comment

Comments

@lenin-jaganathan
Copy link

Currently, all the extended scalars implementing Coercing implement the deprecated apis with only one method parameter. The Scalars can be updated to implement the non-deprecated methods of Coercing.

@Bitbot25
Copy link

This is not a huge problem for me because most of this is hidden away inside the library and does not cause issues outside of maintaining it. One thing that bothers me though, is that AliasedScalar also uses the deprecated APIs. Wrapping your custom scalar type in AliasedScalar causes it to call the deprecated serialize method which throws an exception by default. GraphQL-java explicitly advises against implementing the deprecated methods, not only using them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants