Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse userinfo provided in nomad address #423

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: parse userinfo provided in nomad address #423

wants to merge 5 commits into from

Commits on Sep 13, 2023

  1. fix: parse userinfo provided in nomad address 

    - allow to have a scheme in the address with basic auth
- fix nil point dereference error
    @stind
    stind committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    2430704 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Use net/url to extract userinfo from a URL

    @stind
    stind committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b142593 View commit details
    Browse the repository at this point in the history

  2. Remove unused name attribute from the test cases

    @stind
    stind committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ec3c0c4 View commit details
    Browse the repository at this point in the history

  3. Rename extractBasicAuth to removeBasicAuth 

    to make it more intuitive that the resulting address doesn't include
userinfo
    @stind
    stind committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7138b63 View commit details
    Browse the repository at this point in the history

  4. Improve the signature of removeBasicAuth function

    @stind
    stind committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6eedc89 View commit details
    Browse the repository at this point in the history