Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textDocument/references on a record field in a definition returns way too many things with ghc 9.6.4 #4412

Open
googleson78 opened this issue Oct 4, 2024 · 0 comments
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@googleson78
Copy link
Contributor

This is essentially a duplicate of #3731, because I am now running 9.6.4, and it is still not fixed. I've copied over the original text below.


Is your enhancement request related to a problem? Please describe.

Currently, calling textDocument/references on the field of a record in a definition returns way too many things, including all of the other record fields, as well as the data type definition line, as well as some seemingly duplicate entries. Example:

For this file

{-# LANGUAGE RecordWildCards #-}
data Foo = MkFoo
  {
    bar :: Int,
    baz :: String
  }

fooUse0 :: Foo -> Int
fooUse0 MkFoo{bar} = 5

fooUse1 :: Foo -> Int
fooUse1 MkFoo{..} = 6

fooUse2 :: Int -> String -> Foo
fooUse2 bar baz =
  MkFoo{..}

Calling textDocument/references while my cursor is on bar on line 4 returns the following results:
2023-07-26-165942_636x284_scrot
A lot of these seem redundant:

  1. The constructor definition (the last result)
  2. Some of the lines are seemingly duplicated - fooUse1 and fooUse2 are both seemingly mentioned twice, which seems like a bug?
  3. (my biggest issue) baz :: String also comes up as a result, which also seems like a bug, and is a huge pain when dealing with Real World ™️ data types with loads of fields, as this happens for each field.

Describe the solution you'd like

I would like for only lines that mention the field in question to show up.

Describe alternatives you've considered

Maybe I'm just confused regarding what "references" means?

@googleson78 googleson78 added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

1 participant